jgarciamesa commented 7 years ago

Now handling char - on the conversion of hts version from string to numeric value. Mostly found when HTSLIB is built from a Git repository. Fixes #237 .

reedacartwright commented 7 years ago

We need to be able to unit test our version parser. Split the function into two parts:

hts::version and hts::version_parse`

inline unsigned long version_parse(const char *str) {
/*code*/
}

inline unsigned long version() { return version_parse(hts_version()); }

Then we can create an unit test: hts::hts. to test this version_parse.

codecov[bot] commented 7 years ago

Codecov Report

Merging #238 into develop will increase coverage by 0.02%. The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop     #238      +/-   ##
===========================================
+ Coverage    67.92%   67.94%   +0.02%     
===========================================
  Files           70       70              
  Lines         6520     6521       +1     
  Branches      1140     1140              
===========================================
+ Hits          4429     4431       +2     
+ Misses        1622     1621       -1     
  Partials       469      469

Impacted Files	Coverage Δ
src/include/dng/hts/hts.h	`86.2% <75%> (+4.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b97689f...1a8eeb4. Read the comment docs.

ultimatesource / denovogear

Improved check for HTSLIB version on Unit test #238

Codecov Report