ultraabox / ultrabox_typescript

ultrabox source code
MIT License
34 stars 25 forks source link

Add detune settings in custom samples #151

Closed wdym-lmao closed 6 months ago

leovoel commented 8 months ago

I'm not sure what is meant here. Like adding the root key option for loaded samples instead of only being able to configure that only in the "Add Custom Samples" prompt?

wdym-lmao commented 8 months ago

I meant adding the detune option below the root key option.

leovoel commented 8 months ago

Ah, I see. It could be added, though it wouldn't remain "inherent" to the sample like the "sample rate" or "root key" options, just the automatically created preset (seen under "Custom Sample Presets"). The "inherentness" of some of the properties there is probably confusing...

I'll also note (this probably needs to be documented more clearly) that the "root key" option currently supports decimal numbers, which of course remains regardless of whether you use the associated preset or associated chip wave (due to being "inherent" to the loaded sample data as noted above).

MainCharacteroftheProblem commented 6 months ago

Since this is already more or less covered by Root Key supporting decimal numbers, I'm either going to close this issue or change it so it's about improving documentation

wdym-lmao commented 6 months ago

i should just close it