ultrabug / mkdocs-static-i18n

MkDocs i18n plugin using static translation markdown files
https://ultrabug.github.io/mkdocs-static-i18n/
MIT License
228 stars 38 forks source link

mkdocs-material's tags plugin doesn't fully work with mkdocs-static-i18n #177

Closed markszabo closed 1 year ago

markszabo commented 1 year ago

mkdocs-material has a built-in tags plugin, however it doesn't fully work with mkdocs-static-i18n.

Minimal example

https://github.com/markszabo/mkdocs_i18n_tags_bug

Things that work

Tags show up on the top of the pages in all languages:

image

image

In the main language, the tags page works and shows the tags from the same language

image

Thing that doesn't work

In other languages the tags page is broken

image

The tag links on top of the pages always point to the tags page of the main language

image

Steps to reproduce

  1. Clone the https://github.com/markszabo/mkdocs_i18n_tags_bug repo
  2. Run the mkdocs server, e.g. ./dev-server.sh
  3. Check that http://127.0.0.1:8000/ja/tags/ doesn't show the tags
ultrabug commented 1 year ago

Thanks for this nice and clear report, I'll check that out

champsblanc commented 1 year ago

I have the same problem but i can't even manage to render the tags index in either language. Tags at the top of md documents seem to work fine.

ultrabug commented 1 year ago

Just checking in to acknowledge and apologize for the fact that I did not properly look into this yet.

Once #187 is done, I'll hope to check that out.

usulpt commented 1 year ago

+1 here, couldn't even render the tags in the primary language, found a workaround by excluding the second language files from input (using https://github.com/apenwarr/mkdocs-exclude).

ultrabug commented 1 year ago

Hello I'd like to point out that the upcoming 1.0.0 rework of the plugin happening in #216 will fix this issue. I just tested it and it works properly!

If you're interested, please give a try to #216 and report your experience in the PR!

ultrabug commented 1 year ago

I'm happy to announce release v1.0.0 of the mkdocs-static-i18n plugin!

Please check it out as it should fix this issue! Reopen if needed.

markszabo commented 12 months ago

Thank you very much, and sorry for the delay. I finally got to test it today, and run into an issue. I'll open a new issue about it.