search

ultrabug / mkdocs-static-i18n

MkDocs i18n plugin using static translation markdown files
https://ultrabug.github.io/mkdocs-static-i18n/
MIT License
223 stars 37 forks source link

fix dependency regression from 0.54 #211

Closed kamilkrzyskow closed 1 year ago

kamilkrzyskow commented 1 year ago

Fixes #210

MkDocs 1.2.4 instead of 1.2.3 because the latter has Jinja2 dependency issues itself. Also seems like the MkDocsConfig type hint isn't available pre ~1.4.0

kamilkrzyskow commented 1 year ago

... tox again 💢

ultrabug commented 1 year ago

Thanks for your reactivity mate.

I'm not sure I want to downgrade the plugin's requirement tbh because that's the way forward and we'd be tied to old code. This plugin has to be free to evolve with mkdocs itself.

We might ping Martin of mkdocs-material on the related issue to have his POV on this strange behavior?

kamilkrzyskow commented 1 year ago

Well, it's up to you, adding a try/except with module.__version__ is a quite generic and normal thing to do to support different versions. For the most part the code is the same, it just has some pre-configuration.

OK, I recalled that you said something about the event priorities allowing to remove some redundancy like here https://github.com/ultrabug/mkdocs-static-i18n/commit/67a324bd019d9a0f3b31afb652e06b8e0af64095 So, I guess it's rather important to get the newest bulit-in features and quickly deprecate older versions 🤔

I don't know how docker images work tbh, I'm quite sure that they're running some kind of commands and install dependencies in order. If you think it would be possible for him to update the mkdocs dependency inside of every image, then go for it and ping him in #210

ultrabug commented 1 year ago

So, I guess it's rather important to get the newest bulit-in features and quickly deprecate older versions thinking

That's right, glad you remembered :+1:

ultrabug commented 1 year ago

Also, there was indeed code logic as you mentioned meant to do exactly what the event_priority is doing so supporting both is actually not possible in a clean and maintainable fashion I'm afraid