search

ultrabug / py3status

py3status is an extensible i3status wrapper written in python
https://ultrabug.github.io/py3status/
BSD 3-Clause "New" or "Revised" License
883 stars 259 forks source link

music modules: implement sanitize_words support for all music modules #2234

Open dpeukert opened 4 months ago

dpeukert commented 4 months ago

This PR adds the sanitize_words feature from the spotify module to other music modules. The common functionality has been added to the Py3 module.

I've tested all the modified modules and everything seems to be working as it should.

dpeukert commented 4 months ago

Forgot to run tests, changing to a draft for now.

dpeukert commented 4 months ago

I've fixed the ordering errors, but I wasn't able to fix the docstring errors, which seem to be caused by the default value for sanitize_words being a constant. Not sure how to fix that.

ultrabug commented 3 months ago

@dpeukert would you consider switching to using what @lasers proposes directly?

dpeukert commented 3 months ago

@ultrabug Apart from the ability to be able to configure the sanitized words (some people may want to exlude stuff like "(Live)", some may not), I don't really mind either way.