[NODRIVER] set_all bug, The cookies argument will never be used.

[boludoz]

    async def set_all(self, cookies: List[cdp.network.CookieParam]):
        """
        set cookies

        :param cookies: list of cookies
        :type cookies:
        :return:
        :rtype:
        """
        connection = None
        for tab in self._browser.tabs:
            if tab.closed:
                continue
            connection = tab
            break
        else:
            connection = self._browser.connection
        cookies = await connection.send(cdp.storage.get_cookies())
        await connection.send(cdp.storage.set_cookies(cookies))

Must be:

    async def set_all(self, cookies: List[cdp.network.CookieParam]):
        """
        set cookies

        :param cookies: list of cookies
        :type cookies:
        :return:
        :rtype:
        """
        connection = None
        for tab in self._browser.tabs:
            if tab.closed:
                continue
            connection = tab
            break
        else:
            connection = self._browser.connection
        await connection.send(cdp.storage.set_cookies(cookies))

This line must be deleted: cookies = await connection.send(cdp.storage.get_cookies())

[ultrafunkamsterdam]

You are somewhat right. The implementation was different but I'm afraid something reverted it then. The original implementation does fetch the current cookies, but merges them before inserting . Will have a look at it when there's time

[boludoz]

You are somewhat right. The implementation was different but I'm afraid something reverted it then. The original implementation does fetch the current cookies, but merges them before inserting . Will have a look at it when there's time

The existing ones are automatically replaced and there is no need to do so, I have already tested it.

[boludoz]

anda bug here

[boludoz]

I've reported several bugs and they weren't fixed, I guess every big project needs more than one person on it and you're overwhelmed. Do you mind if I fork it and make some improvements, especially a special function to save iframes as tabs?

[boludoz]

Another thing I would like is to be able to avoid excessive use of awaits like:

await page.find( '//*[@id="loginEmail"]', timeout=10).click() instead:

await (await page.find( '//*[@id="loginEmail"]', timeout=10)).click()

There are some pages that refresh and that would be very useful. The way you used the CDP library is why I will always support this project.

And another one that would help reduce the code required to complete a project is to add boolean functions like if is_found, is_found_and_visible.

[stephanlensky]

Hey @boludoz , I just commented on your other issue https://github.com/ultrafunkamsterdam/undetected-chromedriver/issues/2013, but I've also included this fix in my fork: https://github.com/stephanlensky/zendriver