ultrakorne / better-rolltables

Module for FoundryVTT to improve rolltables
MIT License
32 stars 29 forks source link

"fix text results handled as items when using new tables mode" has not been fixed #117

Open maxobremer opened 3 years ago

maxobremer commented 3 years ago

This issue wasnt fixed. it still turns text into items (also tested it when it wasjust text without something else in the result, such as a scene, still turns text into items.

image

MiahNelah commented 3 years ago

Thanks for your feedback! Damn, I thought I catched it... Can you export your rolltable so I can test it? EDIT: I notice some stuff I implemented, including a fix for this issue, did not get merged on last update. I sent a new PR to fix this.

maxobremer commented 3 years ago

https://we.tl/t-GT5c5hXAoQ there it is. only an issue when using a better rolltable

MiahNelah commented 3 years ago

image Looks like next update will fix this issue 👍

MiahNelah commented 3 years ago

Please update to v1.8.1 and try again. Everything should be fixed.

maxobremer commented 3 years ago

so the issue remains if the text has a reference to an item

image

MiahNelah commented 3 years ago

This is unfortunately a non-supported feature, and I have no idea if it's possible to implement this. I'll need to check deep into foundry's code. If you really want to have this quickly, you should be able to do it by replacing compendium reference with HTML like this:

<a class="entity-link" data-pack="<id of compendium>" data-entity="<type of object>" data-id="<object it>">
     <i class="fas fa-suitcase"></i> Object name
</a>

You can of course put all of this on a single line. Here is an example with Potion of Healing:

<a class="entity-link" data-pack="dnd5e.items" data-entity="Item" data-id="C8AGcvbEDVzgLzYc">
    <i class="fas fa-suitcase"></i> Potion of Healing
</a>
maxobremer commented 3 years ago

wow very quick respons, dont know exactly what to say except that if you use a default table the issue is not there

image

MiahNelah commented 3 years ago

Default table do parse entity link and display a correct link. Better Rolltable only parse this kind of reference (just like when yuou do an Entity or Compendium entry type) when there is no other text. Doing what you want to do is not yet supported :(