Open AngryBeaver opened 1 year ago
jfi: my module just collided with your implementation of isEmpty. i now prefixed mine but i had a look at your methods.
You actually have implemented an ifIsEmpty and i just wanted to point out that some things you implemented are already availabled.
e,g, Do you know you can do {{#if (eq a b)}} or {{#if (not (eq a b)}} <- there is gt lt eq etc alot comming as basic with foundry.
my isEmpty method would be on the same level e.g. {{if (isEmpty a)}} <- that is why we collide as yours is {{#isEmpty a}}
jfi: my module just collided with your implementation of isEmpty. i now prefixed mine but i had a look at your methods.
You actually have implemented an ifIsEmpty and i just wanted to point out that some things you implemented are already availabled.
e,g, Do you know you can do {{#if (eq a b)}} or {{#if (not (eq a b)}} <- there is gt lt eq etc alot comming as basic with foundry.
my isEmpty method would be on the same level e.g. {{if (isEmpty a)}} <- that is why we collide as yours is {{#isEmpty a}}