ultraleap / UnrealPlugin

Ultraleap SDK for the Unreal Engine.
264 stars 68 forks source link

Feature/hands scaling #115

Closed YasserNezzari closed 1 year ago

YasserNezzari commented 1 year ago

Scaling the poly hands and the avatar hands

YasserNezzari commented 1 year ago

Tested with smaller hands (cut from white paper) and bigger hands wearing gloves and both poly hands and avatar hands were scaling up and down accordingly, when you click on calibrate button in the hand menu. Docs here how to use: https://gitlab.ultrahaptics.com/marcom/ultraleap-api-docs/-/commit/a3ba3b1cb198db6d80731922af5ff82bc3bfdb31

Greg-UL commented 1 year ago

Interesting I thought the scaling should be present prior to the calibration button being pressed for the avatar, at least the poly hands definitely should be. Might be good to get this packaged up and tested on android too before pushing this further.

YasserNezzari commented 1 year ago

@Greg-UL it can be done on tick, but that would be expensive, the reason I done on button press, is for the user to hold their hands in front of the tracking camera, and that would give more precise scaling without affect the performance. but if you want it done without button press no problem

Greg-UL commented 1 year ago

I think the poly models should be scaling without any need for the calibration button to be pressed. I don't mind if the avatar ones scale after pressing the buttonI guess my only question would be how does this look without the button being pressed.

YasserNezzari commented 1 year ago

@Greg-UL I just committed code to auto scale the poly hands, without the need for button press https://github.com/ultraleap/UnrealPlugin/commit/15bbf4ee2cc44c05aab875db2771c1c37cb2cbf2