Sourcery refactored master branch

[sourcery-ai[bot]]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

🛠️ PR Summary

_{Made with ❤️ by Ultralytics Actions}

🌟 Summary

Modernization and improvement of code quality in Flickr scraper and image cleaning utilities.

📊 Key Changes

• Flickr scraper now uses f-string formatting for constructing image URLs.
• clean_images.py script replaces various symbols in filenames with underscores, handles query strings, adds missing image format suffixes, and includes clearer printing messages with f-string.
• Enhanced logic to include checks for missing suffixes and potentially resized images to maintain a maximum width/height ratio.
• Generalized the handling of exceptions by printing warnings and removing corrupted files if necessary.

🎯 Purpose & Impact

• These changes make the code more readable and maintainable by adopting modern Python conventions (f-strings), leading to easier debugging and enhancement in the future.
• The improved file name sanitation and suffix checking will help in avoiding issues related to operating systems' file handling and inconsistencies.
• More informative print statements and error handling provide a better user experience by clearly indicating what actions the scripts are performing and alerting users to any issues.
• Overall, these updates contribute to a smoother, more efficient and user-friendly interaction with the Ultralytics Flickr scraping and image cleaning tools, which can be very helpful for users working on machine learning datasets and image processing tasks. 📈🧹

[sourcery-ai[bot]]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.61%.

Quality metrics	Before	After	Change
Complexity	29.96 😞	29.96 😞	0.00
Method Length	146.33 😞	148.56 😞	2.23 👎
Working memory	10.05 😞	10.32 😞	0.27 👎
Quality	38.47% 😞	37.86% 😞	-0.61% 👎

Other metrics	Before	After	Change
Lines	259	257	-2

Changed files	Quality Before	Quality After	Quality Change
flickr_scraper.py	58.30% 🙂	55.66% 🙂	-2.64% 👎
utils/clean_images.py	29.27% 😞	29.19% 😞	-0.08% 👎
utils/general.py	66.67% 🙂	66.54% 🙂	-0.13% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
utils/clean_images.py	scan	59 ⛔	500 ⛔	12 😞	15.14% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
utils/clean_images.py	scan.scan_one_file	18 🙂	306 ⛔	9 🙂	38.64% 😞	Try splitting into smaller methods
flickr_scraper.py	get_urls	16 🙂	174 😞	13 😞	40.49% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!