Solved find_element_by_tag_name deprecated error - Githubissues

ultralytics / google-images-download

Google/Bing Images Web Downloader

https://ultralytics.com

GNU Affero General Public License v3.0

294 stars 84 forks source link

Solved find_element_by_tag_name deprecated error #14

Closed FareedKhan-dev closed 7 months ago

FareedKhan-dev commented 1 year ago

I encountered a very basic issue within this repository (While running bing_scraper.py)

'WebDriver' object has no attribute find_element_by_tag_name.

Since find_element_by_tag_name has been depreciated in Selenium. Source 1: Official Documentation Link Source 2: GitHub Issue

The alternative approach is to use find_element(By.TAG_NAME, "your_html_tag"), as I have updated the bing_scraper.py, Kindly review it.

Thank you!

I have read the CLA Document and I sign the CLA

🛠️ PR Summary

_{Made with ❤️ by Ultralytics Actions}

🌟 Summary

Enhanced compatibility for Bing image scraper with latest Selenium practices.

📊 Key Changes

Imported By class from the selenium.webdriver.common.by module.
Replaced the deprecated find_element_by_tag_name with the updated find_element method, utilizing the By class for specifying the element search criteria.

🎯 Purpose & Impact

Purpose: The update ensures that the Bing scraper in the repository is using the latest Selenium methods, maintaining compatibility with newer versions of the Selenium package.
Impact: Users of the scraper will benefit from code that adheres to the current best practices, potentially resulting in more reliable scraping and less maintenance work due to deprecated functionality. 🛠️🔄

glenn-jocher commented 7 months ago

@FareedKhan-dev PR merged, thank you for your contributions!