ultralytics / yolo-flutter-app

A Flutter plugin for Ultralytics YOLO computer vision models
https://ultralytics.com
GNU Affero General Public License v3.0
111 stars 43 forks source link

YoloModel adds the isLive property #16

Closed x2031 closed 6 months ago

x2031 commented 7 months ago

15

YoloModel adds the isLive property.Used to control whether or not to scale the resultant coordinates in the detectImage method.

I have read the CLA Document and I sign the CLA

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvements to accuracy and usability in YOLO Flutter App.

πŸ“Š Key Changes

🎯 Purpose & Impact

x2031 commented 7 months ago

I only changed the code for Android, I'm not familiar with ios so I didn't change it.

pderrenger commented 7 months ago

Hello! 😊 Thank you for contributing to the project and enhancing the Android experience with the isLive feature. For consistency and to benefit all users, it's important to have this feature available on both Android and iOS. I understand you're not familiar with iOS development - that's totally fine! Could you please submit a pull request for the changes you've made for Android? This way, someone else from the community or our team who has iOS experience can work on adapting your changes for iOS. In your pull request, it would be helpful to briefly document how you implemented the isLive feature for Android, so it's easier for the next contributor to mirror those changes on iOS. πŸš€

If you need guidance on making a pull request or documenting your changes, our documentation at https://docs.ultralytics.com provides some great tips and best practices. Thanks again for your contribution! Together, we're making the project even better. 🌟

x2031 commented 7 months ago

Hello! 😊 Thank you for contributing to the project and enhancing the Android experience with the isLive feature. For consistency and to benefit all users, it's important to have this feature available on both Android and iOS. I understand you're not familiar with iOS development - that's totally fine! Could you please submit a pull request for the changes you've made for Android? This way, someone else from the community or our team who has iOS experience can work on adapting your changes for iOS. In your pull request, it would be helpful to briefly document how you implemented the isLive feature for Android, so it's easier for the next contributor to mirror those changes on iOS. πŸš€

If you need guidance on making a pull request or documenting your changes, our documentation at https://docs.ultralytics.com provides some great tips and best practices. Thanks again for your contribution! Together, we're making the project even better. 🌟

I've submitted the code and what else do I need to do?

pderrenger commented 7 months ago

Hello! 😊 Fantastic job on submitting the pull request, and thank you for your efforts in enhancing the project. Here are a couple of quick steps to ensure everything is in place:

  1. PR Description: Make sure your pull request includes a concise but comprehensive description of what changes you've made and how they contribute to the feature. This description helps reviewers understand your approach and its impact.

  2. Documentation: If you've added new functionality or altered existing features, briefly document how to use the isLive feature, including any new parameters or methods. This information is incredibly useful for both the reviewers and future users.

  3. Wait for Review: Our team will review your submission. During this time, you might receive feedback or requests for changes. Keep an eye on your GitHub notifications for updates.

  4. Engage with Feedback: If there are suggestions or required changes, please address them promptly. Your responsiveness will help speed up the merge process.

That's all! Thanks again for your contribution. We deeply appreciate your efforts to improve the project. πŸ‘ If you have any more questions or need further assistance, feel free to ask.