ultralytics / yolov5

YOLOv5 🚀 in PyTorch > ONNX > CoreML > TFLite
https://docs.ultralytics.com
GNU Affero General Public License v3.0
50.64k stars 16.32k forks source link

Fatal error, thread unsafe!!! #11338

Closed SethWen closed 1 year ago

SethWen commented 1 year ago

https://github.com/ultralytics/yolov5/blob/1db95338cf5091db8e3e67395e4487da0e1ee51d/models/yolo.py#L65

The code here is thread-unsafe。 When executed concurrently, the following error will occur. RuntimeError: The size of tensor a (24) must match the size of tensor b (32) at non-singleton dimension 2

This is because the member variables self.anchor_grid and self.grid are modified in multithreading, which cause data confusion. Please consider to use local variables, and do not modify self.anchor_grid and self.grid.

github-actions[bot] commented 1 year ago

👋 Hello @SethWen, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset image examples and training logs, and verify you are following our Tips for Best Training Results.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

YOLOv5 CI

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training, validation, inference, export and benchmarks on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

Introducing YOLOv8 🚀

We're excited to announce the launch of our latest state-of-the-art (SOTA) object detection model for 2023 - YOLOv8 🚀!

Designed to be fast, accurate, and easy to use, YOLOv8 is an ideal choice for a wide range of object detection, image segmentation and image classification tasks. With YOLOv8, you'll be able to quickly and accurately detect objects in real-time, streamline your workflows, and achieve new levels of accuracy in your projects.

Check out our YOLOv8 Docs for details and get started with:

pip install ultralytics
glenn-jocher commented 1 year ago

@SethWen , thanks for sharing your concern. You are correct that Ultralytics YOLOv5 code at that position might not be thread-safe. We are actively working on improving thread-safety in our codebase. Would you mind providing more context about your use case? Are you referring to multi-thread inference or multi-thread training?

We are always looking to improve our codebase and appreciate your feedback. If you have any pull requests or proposed solutions, please feel free to create an issue, and we will review it.

SethWen commented 1 year ago

Thanks for your reply. I deploy yolo model as a service for inference. To fix this issue, I create a PR-11343, review it please.

glenn-jocher commented 1 year ago

Thank you @SethWen for creating the pull request to address the thread-safety issue. We appreciate your contribution to the project. Our team will review the PR, and we will get back to you on any additional feedback or comments.

github-actions[bot] commented 1 year ago

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐