ultramango / gear360pano

Simple script to create equirectangular panorama by stitching images from Samsung Gear 360
MIT License
225 stars 55 forks source link

Typo in gear360pano, wrong pto #28

Closed kwahoo2 closed 6 years ago

kwahoo2 commented 7 years ago

I encountered two small issues during video processing: First one,

WARN: 21:34:11.630426 (/build/hugin-4U_FiW/hugin-2016.2.0~rc2+dfsg/src/hugin_base/panodata/Panorama.cpp:2054) readData(): Failed to read from dataInput. error while parsing panos tool script: ./gear360sm-c210.pto Error while running nona Fix:

Line in gear360pano.cmd:

PTOTMPL_SM_C200="$DIR/gear360sm-c210.pto" should be: PTOTMPL_SM_C200="$DIR/gear360sm-c200.pto"

Second one: remapImage(): image sizes not consistent

The video script tried to use gear360sm-c200.pto instead gear360video.pto for some reason.

evertvorster commented 7 years ago

Confirm both issues.

neuhaus commented 7 years ago

opened pull request #29 for this issue.

Tip: Don't put two issues in one issue. Open a separate issue for each.

ultramango commented 7 years ago

Thanks for the fix. I'll have a look at the second one.

BTW: I will finally have to do something about supporting different input image sizes, even through upscaling, as it might be a bit annoying.

ultramango commented 6 years ago

Hmm... I think I fixed that already.

Support for other image formats will come.

hamada8899 commented 6 years ago

Have you fixed the issue of different input image sizes or not yet ? Because I tried to re-clone the code then I tried also to resize my images and video as you mentioned but still get an error that says failed to read from data input, incorrect number of images specified. Any help

ultramango commented 6 years ago

Hi,

Different input image sizes - not yet. As a quick-fix I plan to just resize the image so it will be useable with the existing pto file. In the long run I want to create different pto files for different size.

I'll try to reproduce the problem on my side. I suspect that the images are fine, just the script behaves in a bad way.

BTW: are you using bash as your default shell? What /usr/sh points to? Can you run the script with bash explicitly?

L.

evertvorster commented 6 years ago

Hi there..

I tried simply resizing images and re-using the pto for video, but got horrible stitching errors. It appears that the camera uses a different part of the sensor for photos and videos. My workaround is to use maximum resolution for everything, and two different pto for photo and video.

I don't know if this holds true for different resolutions, but I would not be surprised either way.

-Evert-

On 17 October 2017 at 20:25, ultramango notifications@github.com wrote:

Hi,

Different input image sizes - not yet. As a quick-fix I plan to just resize the image so it will be useable with the existing pto file. In the long run I want to create different pto files for different size.

I'll try to reproduce the problem on my side. I suspect that the images are fine, just the script behaves in a bad way.

BTW: are you using bash as your default shell? What /usr/sh points to? Can you run the script with bash explicitly?

L.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ultramango/gear360pano/issues/28#issuecomment-337276176, or mute the thread https://github.com/notifications/unsubscribe-auth/ALfL1YLGnNFMeIFK0lh9ohBNm36MSrU_ks5stNThgaJpZM4OMqCn .

-- Evert Vorster Isometrix Acquistion Superchief

hamada8899 commented 6 years ago

First of all, thanks for your fast replies Would it be possible for u to attach for me a hugin .pto project file that can stitch a video frame with dimensions 4096x2048. I believe it will solve my problem and then I am gonna change the rest of the settings to make it work. Here is a sample frame

I have tried to follow the steps that you mentioned in this video but unfortunately that didn't work well with me

ultramango commented 6 years ago

I can give it a try over the weekend (hopefully).

With this frame the quality of .pto file might be poor (or I might fail to create it at all):

Let me know what camera is this (is it Gear360 gen2?) and I'll try to find some samples.

As for upscaling - I'm surprised that it didn't work... I will have to see with my own eyes then.

L.

hamada8899 commented 6 years ago

Yes It is, it produces a video for the time lapse mode with resolution 4096x2048. Thanks for helping

ultramango commented 6 years ago

Try this template file: https://ufile.io/bwgmi . Here's the stitching result (enblend) of sample image: https://ufile.io/evuw6 .

Let me know about the results.

L.

hamada8899 commented 6 years ago

Wow you Rock, Thanks a lot for your time and effort. Very appreciated, my problem is solved thanks

dustinkerstein commented 6 years ago

@ultramango would you be able to post that template file again? I'm running into the same issue with 4096x2048 footage. Thanks.

ultramango commented 6 years ago

I added support for 4096 videos, please check the script. Template that you are interested in is gear360video4096.pto.

ultramango commented 6 years ago

For more image formats I created dedicated issue #51. Closing this one.