ultramango / gear360pano

Simple script to create equirectangular panorama by stitching images from Samsung Gear 360
MIT License
226 stars 55 forks source link

fix 'argument list too long' #44

Closed impca closed 6 years ago

impca commented 6 years ago

When processing long videos, they get split into a large number of individual frames. Then, during the assembly of said frames, bash expands the *.jpg into very long command line, hits the limit and fails.

This commit uses find to avoid this situation.

ultramango commented 6 years ago

Thanks for the fix.

L.

FlorianFranzen commented 6 years ago

This breaks the script for me on Ubuntu 16.04. with all current updates.

Extracting frames from video (this might take a while)...
ffmpeg version 2.8.11-0ubuntu0.16.04.1 Copyright (c) 2000-2017 the FFmpeg developers
  built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.4) 20160609
  configuration: --prefix=/usr --extra-version=0ubuntu0.16.04.1 --build-suffix=-ffmpeg --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --cc=cc --cxx=g++ --enable-gpl --enable-shared --disable-stripping --disable-decoder=libopenjpeg --disable-decoder=libschroedinger --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librtmp --enable-libschroedinger --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzvbi --enable-openal --enable-opengl --enable-x11grab --enable-libdc1394 --enable-libiec61883 --enable-libzmq --enable-frei0r --enable-libx264 --enable-libopencv
  libavutil      54. 31.100 / 54. 31.100
  libavcodec     56. 60.100 / 56. 60.100
  libavformat    56. 40.101 / 56. 40.101
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 40.101 /  5. 40.101
  libavresample   2.  1.  0 /  2.  1.  0
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  2.101 /  1.  2.101
  libpostproc    53.  3.100 / 53.  3.100
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '360_0007.MP4':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: qt  isomhvc1
    creation_time   : 2016-01-01 12:01:08
  Duration: 00:00:10.93, start: 0.000000, bitrate: 30000 kb/s
    Stream #0:0(eng): Video: hevc (Main) (hvc1 / 0x31637668), yuv420p(tv), 2560x1280, 29784 kb/s, 59.94 fps, 59.94 tbr, 120k tbn, 120k tbc (default)
    Metadata:
      creation_time   : 2016-01-01 12:01:08
      handler_name    : VideoHandler
      encoder         : DRIMeV HEVC Encoder
    Stream #0:1(eng): Audio: aac (LC) (mp4a / 0x6134706D), 48000 Hz, stereo, fltp, 189 kb/s (default)
    Metadata:
      creation_time   : 2016-01-01 12:01:08
      handler_name    : SoundHandler
[swscaler @ 0x221e1c0] deprecated pixel format used, make sure you did set range correctly
Output #0, image2, to '/tmp/tmp.Ivbx6JHTXZ/image%05d.jpg':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: qt  isomhvc1
    encoder         : Lavf56.40.101
    Stream #0:0(eng): Video: mjpeg, yuvj420p(pc), 2560x1280, q=2-31, 200 kb/s, 59.94 fps, 59.94 tbn, 59.94 tbc (default)
    Metadata:
      creation_time   : 2016-01-01 12:01:08
      handler_name    : VideoHandler
      encoder         : Lavc56.60.100 mjpeg
Stream mapping:
  Stream #0:0 -> #0:0 (hevc (native) -> mjpeg (native))
Press [q] to stop, [?] for help
frame=  655 fps= 31 q=2.0 Lsize=N/A time=00:00:10.92 bitrate=N/A    
video:141083kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown
Stitching frames...
xargs: run_command: No such file or directory
Recoding the video...
ffmpeg version 2.8.11-0ubuntu0.16.04.1 Copyright (c) 2000-2017 the FFmpeg developers
  built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.4) 20160609
  configuration: --prefix=/usr --extra-version=0ubuntu0.16.04.1 --build-suffix=-ffmpeg --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --cc=cc --cxx=g++ --enable-gpl --enable-shared --disable-stripping --disable-decoder=libopenjpeg --disable-decoder=libschroedinger --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librtmp --enable-libschroedinger --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzvbi --enable-openal --enable-opengl --enable-x11grab --enable-libdc1394 --enable-libiec61883 --enable-libzmq --enable-frei0r --enable-libx264 --enable-libopencv
  libavutil      54. 31.100 / 54. 31.100
  libavcodec     56. 60.100 / 56. 60.100
  libavformat    56. 40.101 / 56. 40.101
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 40.101 /  5. 40.101
  libavresample   2.  1.  0 /  2.  1.  0
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  2.101 /  1.  2.101
  libpostproc    53.  3.100 / 53.  3.100
[image2 @ 0x1bad4c0] Could find no file with path '/tmp/tmp.5sKYFmQTML/image%05d_pano.jpg' and index in the range 0-4
/tmp/tmp.5sKYFmQTML/image%05d_pano.jpg: No such file or directory
Error while running ffmpeg
Removing temporary directories...
impca commented 6 years ago

Oops, my bad. https://stackoverflow.com/questions/11003418/calling-shell-functions-with-xargs

It will probably be required to replace run_command on line 243 with bash -c 'run_command "$@"' _. Can you try it?