ultrasaurus / webgenr

experimental
Apache License 2.0
1 stars 1 forks source link

consider mime crate to support more features easily... #26

Open ultrasaurus opened 1 year ago

ultrasaurus commented 1 year ago

We need to detect all the media types supported by EPUB, so considering using a crate which is maintained and well-tested, supporting:

Options:

ultrasaurus commented 1 year ago

I'm not fond of Mime crate

However, its maintainers make what seem to be good arguments about the hyper use case which lead to a bunch of the design decisions that some folks dislike, and different crates are making different tradeoffs

I don't understand our use case well enough, so just went with Mime to learn about it and will leave as is until I get a bit more experience with what is needed.

Closing for now, since PR merged that uses Mime. Feel free to re-open if there are any compelling arguments to use a different crate!

ultrasaurus commented 10 months ago

note: mime_guess doesn't do the right thing for .m4a files, https://github.com/abonander/mime_guess/issues/88

ultrasaurus commented 7 months ago

could also consider https://github.com/Lynnesbian/new_mime_guess (fork of mime_guess)

added to list in issues description with notes