search

ultrasonicsoft / ng-connection-service

Detects active internet connection in Angular application via DI ready Observable service.
84 stars 56 forks source link

Support for Angular 16 and 17 in ng-connection-service #158

Closed anandkushwaha064 closed 3 months ago

anandkushwaha064 commented 4 months ago

Hello,

I've made some updates to the ng-connection-service to add support for Angular versions 16 and 17. Below are the details of the changes included in this pull request:

Files Updated:

  1. angular.json
  2. package-lock.json
  3. package.json
  4. projects/ng-connection-service/package.json
  5. projects/ng-connection-service/tsconfig.lib.prod.json
  6. README file

Key Changes:

  1. Updated tsconfig.lib.prod.json to use Angular's partial compilation mode, which is required for Angular versions starting from 16. This change moves away from the deprecated View Engine (Ivy disabled) setting:

    "angularCompilerOptions": {
  "compilationMode": "partial"
}

    This replaces the previous configuration:

    "angularCompilerOptions": {
  "enableIvy": false
}
  2. Updated the version in projects/ng-connection-service/package.json from the previous 12.x.x to 13.0.0 to reflect the significant changes and improvements made for compatibility with Angular 16 and 17.

These updates ensure that ng-connection-service remains compatible with the latest Angular versions and follows the best practices recommended by the Angular team for library development.

Thank you for considering this contribution. I look forward to your feedback and hope this enhancement can be integrated to benefit all users of the library.

Best regards, Anand Kushwaha