search

ultrasound1372 / NVDA-IBMTTS-Driver

This progect is to develop and maintain the NVDA IBMTTS driver. This repository is responsible for the x0_personal versions, which are continuing development even after it seems activity from the base repository has stopped.
GNU General Public License v2.0
1 stars 0 forks source link

Several fixes #2

Closed Mohamed00 closed 4 years ago

Mohamed00 commented 4 years ago

This pull request renames main and root.dic to enuroot and enumain.dic respectively for compatibility with SAPI4 versions of IBMTTS and Eloquence, adds support for the abbreviation dictionary, available by creating a file named enuabbr.dic and placing it in the ibmtts directory, and also adds a toggle to enable or disable phrase prediction.

ultrasound1372 commented 4 years ago

Review

if the file enuroot.dic or enumain.dic doesn't exist but the language is American English, the add-on should attempt fallback to root.dic and main.dic for those respective files, as a backwards compatibility measure. Other languages could just not load as normal.

Questions

  1. Phrase prediction is off by default, right?
  2. Did you add a checkbox for the toggle of abbreviation dictionaries? I think this affects internal dict and external ones, and should be off by default.
Mohamed00 commented 4 years ago

Yes, Phrase Prediction and the abbreviation dictionary should be off by default in new configurations. Your review comments should be addressed in the last commit.

ultrasound1372 commented 4 years ago

I noticed you added more commits after your message. Are we good to merge or is there something else waiting to be pushed?

Mohamed00 commented 4 years ago

We can merge now. The last two were just a few issues here and there and I didn't notice initially.