search

ultrasound1372 / NVDA-IBMTTS-Driver

This progect is to develop and maintain the NVDA IBMTTS driver. This repository is responsible for the x0_personal versions, which are continuing development even after it seems activity from the base repository has stopped.
GNU General Public License v2.0
1 stars 0 forks source link

New anticrash expression #6

Closed Mohamed00 closed 4 years ago

Mohamed00 commented 4 years ago

This pull request adds a new crash expression for juaras, as well as juares, juaros, and juarus. While these can cause the synth to make fun noises, they can also crash it if used the right way.

ultrasound1372 commented 4 years ago

I was reluctant to add this one. Do we know the circumstances under which it crashes? I think it has something to do with end of string? Otherwise it just slides or glitches. And how many people would actually know how to make it crash, rather than just making it glitch? If it can be crashed reliably with a given pattern that could be deduced, then yeah I'd add it, but I'd rather avoid false positives if possible.

Mohamed00 commented 4 years ago

Yes, it can be crashed with something like juaras aaaaaaaaaaaaaa aaaa, delete the space of course. It only works on its own, though, the patterns that make the synth glitch won't be caught here.

Mohamed00 commented 4 years ago

It seems that the pattern is juaras, juaros, juarus or juares, and then at least nine A's and then another letter, though some symbols such as _ can do it as well, so I thought it would be better to just mask out that pattern on its own.

ultrasound1372 commented 4 years ago

It works if you send a bunch of i's or o's directly after it as well, and I can make the regex more compact with a character class instead of the heavier alternation. I'll merge this but then make some edits, as e juarosjuarasausausjasjajusjausjausjaujsuajsua o still works, even though the string is rather scrambled.