search

ultrasoundmoney / frontend

ultrasound.money frontend
https://ultrasound.money
MIT License
212 stars 66 forks source link

Add additional timeframes and make them consistent across backward looking graphs / tables #263

Open ckoopmann opened 1 year ago

ckoopmann commented 1 year ago

Currently the website supports different timeframes:

Eth-Supply Graph: 5m, 1h, 1d, 7d, 30d, since merge

All other graphs / tables: 5m, 1h, 1d, 7d, 30d, since burn

Suggestion:

ckoopmann commented 1 year ago

Would love to give this a shot if it is judged a desirable change. (Although I guess it would also require backend changes maybe ? Any feedback on the expected complexity / scope of this would be appreciated).

ckoopmann commented 1 year ago

Noticed that these suggestions are partially contained in: https://github.com/ultrasoundmoney/frontend/issues/244 https://github.com/ultrasoundmoney/frontend/issues/241

thegoodwei commented 1 year ago

I love this dashboard. I only suggest implementing 90-day (and eventually 1-year) time frames for all dashboard stats, with snapshots per quarter. Users want to view the burnt supply of eth in usd value per annum and quarter. That would make an easier comparison with corporate earnings reports from traditional saas companies over that same time period.

ckoopmann commented 1 year ago

I started hacking on this a little bit but then was blocked by the grouped-analysis-1 endpoint of the api not returning data for the merge timeframe and also being unable to find the implementation of that endpoint in the backend codebase. See: https://github.com/ultrasoundmoney/eth-analysis-rs/issues/8

alextes commented 1 year ago

@thegoodwei noted. 1y is already on our wishlist. Didn't know people would like 90-day too. Can you provide more details? Do you monitor it, copy it, do you use this data for anything? and hypothetically, would this even ideally be a dashboard for your use-case. e.g. would it be more useful still if it came as a neat CSV?

@ckoopmann apologies for the slow reply, the backend part is indeed missing! and it's what I'm working on right now. Once I have it I'll likely implement the frontend myself but if I could use the help can I ping you here?

ckoopmann commented 1 year ago

@thegoodwei noted. 1y is already on our wishlist. Didn't know people would like 90-day too. Can you provide more details? Do you monitor it, copy it, do you use this data for anything? and hypothetically, would this even ideally be a dashboard for your use-case. e.g. would it be more useful still if it came as a neat CSV?

@ckoopmann apologies for the slow reply, the backend part is indeed missing! and it's what I'm working on right now. Once I have it I'll likely implement the frontend myself but if I could use the help can I ping you here?

No problem, that sounds great. I'd love to do the frontend adjustments, which seem pretty straight forward, or help in any way possible. Feel free to ping me if I can be of help🙏 I'm also more than happy to help on the backend side btw. \

Just out of curiosity: Where is the api/fees/grouped-analysis-1 api endpoint implemented ? I couldn't find the implementation anywhere in the open sourced backend code 🤔 (also opened an issue for this in the backend repo )

alextes commented 1 year ago

@ckoopmann awesome!

That API is in the older typescript repo. Sent you an invite. Happy to take PRs there too.