search

ultrasoundmoney / frontend

ultrasound.money frontend
https://ultrasound.money
MIT License
216 stars 73 forks source link

LatestBlock #264

Closed UsuaOSilver closed 1 year ago

UsuaOSilver commented 1 year ago

add color to Latest Block baseFeePerGas

Changes on the files below:

This branch is developed on top of PR#261, which has not been merged, leading to the inclusion of changes in other files listed above.

alextes commented 1 year ago

Hmm, with this based on top of the other branch it's hard for me to review. I think is the simplest is to just leave this. Work on getting the other branch merged first, and then this one will automatically become based on top of main and this diff should become a bit cleaner.

The other alternative is to rebase this one onto main but that's more complicated.

UsuaOSilver commented 1 year ago

I was working on this task since I saw it's not marked done in Coda so I forked this branch from my working branch in ultrasoundmoney/frontend and I realized my branch is not up to date after testing the main branch of ultrasoundmoney/frontend and saw that this problem has been solved. I will delete this PR

alextes commented 1 year ago

@UsuaOSilver yea, sorry. I didn't think you were still working on this and ended up tackling it myself a couple days before you opened this. Sorry!

UsuaOSilver commented 1 year ago

np Alex! I'm reading on your code to see how you did it!