search

ultrastares / ultrastar-worldparty

UltraStar WorldParty. A karaoke game inspired by SingStar™
https://ultrastar-es.org
GNU General Public License v3.0
135 stars 35 forks source link

Duet: Player tags #2

Closed MairusuPawa closed 9 years ago

MairusuPawa commented 9 years ago

Hello,

Multiple Ultrastar forks (USDX-CMD, USDX-WP, Vocaluxe…) are working on implementing a duet mode. When selecting a song, players are able to pick which part they want to sing according to singer names set in the TXT file. However, the tags used for this are inconsistant among forks.

For instance, Vocaluxe uses:

P1:Kiki Dee

#P2:Elton John

While USDX World Party uses:

DUETSINGERP1:Kiki Dee

#DUETSINGERP2:Elton John

Proposal: take into account either type of tag, so all duet TXT files can be used without modifications. Ideally, define a common format among projects?

TeLiXj commented 9 years ago

Hi again! Vocaluxe started to work in duets after UltraStar versions, and all songs created from this point have UltraStar tags... We may change WorldParty to add Vocaluxe support, but I prefer be more descriptive with UltraStar tags. Vocaluxe must change!!!

MairusuPawa commented 9 years ago

From what I posted on the us-es forums

Vocaluxe is simply using what USDX-CMD used, since it's (approximately) the same dev team. I don't want to take sides here, I just wanted to make you aware that people will use both options when creating txt files and they will be somewhat incompatible. It won't break the game, but that's a bit sad.

I'm not sure how USDX handles names checks, but my basic idea would be to implement this kind of stuff:

If (#DUETSINGERP1) exists → then use #DUETSINGERP1 if not, then if #P1 exists → then use #P1 if not, do nothing

… and hopefully, USDX-CMD / Vocaluxe / Performous / etc. will also use the same way of looking up singer names, so it won't matter to the end-user and no one would have to rewrite the TXT files (which is a task everyone wants to avoid, it's cumbersome and they're already distributed everywhere with no way of changing them).