search

ultrastares / ultrastar-worldparty

UltraStar WorldParty. A karaoke game inspired by SingStar™
https://ultrastar-es.org
GNU General Public License v3.0
134 stars 35 forks source link

Song with just a special character as title crashes ultrastar worldparty #95

Closed IchbinkeinReh closed 5 months ago

IchbinkeinReh commented 5 months ago

Steps to reproduce:

  1. Unzip CrashSong.zip and put it into your song folder
  2. Configure folder mode to be enabled
  3. Start ultrastar worldparty and go to song list
  4. Crash happens

Alternatively to step 1, just open any song and replace the TITLE with just a questionmark (eg #TITLE:? )

Screenshot 2024-04-03 205902

Daniel20Ultrastar-es commented 5 months ago

It works perfectly in stable and development version, Have you tried in other computer?

IchbinkeinReh commented 5 months ago

Thank you very much for the quick reply. I could not reproduce it anymore. I could swear i tested i a few times before i opened the issue. However i

@Daniel20Ultrastar-es may i ask you about another issue i have? I have a pretty big collection of songs (~24000) when i try to load them with UltraStar Deluxe i have no problems bit it takes ~10 minutes till it starts, with UltraStar WorldParty it starts withing 30 seconds which is impressive. Songs load fine in main menu, but as soon as i want to go to the song list this crash happens Screenshot 2024-04-03 194210 Any idea what i can do?

I already experimented a bit and it seems to be no specific song but just the total amount of songs. if i split the songs into different folders and only load ~21000 then i can access the song list.

IchbinkeinReh commented 5 months ago

@Daniel20Ultrastar-es i was able to reproduce the issue again. It only happens if folder mode is enabled!

Daniel20Ultrastar-es commented 5 months ago

I don't have such a large number of songs, but surely the problem comes from a defective song. Folder mode should works fine.

we only support songs from our website. Many of the songs coming from other websites, such as USDB, contain MANY bugs.

Edit: this bug is already fixed in the development version

IchbinkeinReh commented 5 months ago

ok thank you. then i will close this issue. is there any place i can download development builds or do i need to compile myself?

Daniel20Ultrastar-es commented 5 months ago

we'll release a new version in the coming months (surely for summer), until then, you can compile yourself the development builds.