ultravideo / uvg266

An open-source VVC encoder based on Kvazaar
BSD 3-Clause "New" or "Revised" License
225 stars 16 forks source link

MSYS2/MinGW/GCC 14.2: incompatible pointer type in search_ibc.c #23

Closed LigH-de closed 2 months ago

LigH-de commented 2 months ago
[35/92] Building C object CMakeFiles/uvg266.dir/src/search_ibc.c.o
FAILED: CMakeFiles/uvg266.dir/src/search_ibc.c.o 
G:\MABS\msys64\mingw64\bin\ccache.exe  gcc -DUVG_DLL_EXPORTS -IG:/MABS/build/uvg266-git/src -IG:/MABS/build/uvg266-git/src/extras -IG:/MABS/build/uvg266-git/src/strategies -D_FORTIFY_SOURCE=2 -fstack-protector-strong -mtune=generic -O2 -pipe -D__USE_MINGW_ANSI_STDIO=1 -mthreads -O3 -DNDEBUG -MD -MT CMakeFiles/uvg266.dir/src/search_ibc.c.o -MF CMakeFiles\uvg266.dir\src\search_ibc.c.o.d -o CMakeFiles/uvg266.dir/src/search_ibc.c.o -c G:/MABS/build/uvg266-git/src/search_ibc.c
G:/MABS/build/uvg266-git/src/search_ibc.c: In function 'check_mv_cost_satd':
G:/MABS/build/uvg266-git/src/search_ibc.c:231:65: error: passing argument 3 of 'calculate_ibc_cost_satd' from incompatible pointer type [-Wincompatible-pointer-types]
  231 |   double cost = calculate_ibc_cost_satd(info->state, info->lcu, &info->origin, x, y);
      |                                                                 ^~~~~~~~~~~~~
      |                                                                 |
      |                                                                 vector2d_t *
G:/MABS/build/uvg266-git/src/search_ibc.c:113:99: note: expected 'const cu_loc_t *' but argument is of type 'vector2d_t *'
  113 | static uint32_t calculate_ibc_cost_satd(const encoder_state_t *state, lcu_t* lcu, const cu_loc_t* loc, int32_t mv_x, int32_t mv_y)
      |                                                                                   ~~~~~~~~~~~~~~~~^~~

logs.zip collected by M-AB-S

fador commented 2 months ago

Thanks for the report, it was an easy fix since that was just a dummy function supposed to be used later, so removed for now 😁