search

ultravideo / uvgRTP

An open-source library for RTP/SRTP media delivery
BSD 2-Clause "Simplified" License
325 stars 92 forks source link

RTCP spam #139

Closed wowaser closed 2 years ago

wowaser commented 2 years ago

Hello,

I have pulled latest (e5fefc9) and have been experiencing the following spam from RTCP: image

This does not seem to break any RTCP functionality, just really annoying. I commented it out for now

jrsnen commented 2 years ago

This is probably a duplicate of #137 Also related to #126

The RTCP packet length should always be measured in 32-bit words. I'm guessing from your previous issues that you are using APP packets, but unfortunately, uvgRTP does not have padding implemented for APP or SDES messages. What this means is that if you send a message that is not measured in 32-bit words, the end gets lost at the receiver now that I implemented support for compound packets (which by the way all RTCP packets should be, including APP, see #91).

What you should probably do in APP packets is to write the length of the payload yourself to the data (if not measurable in 32-bit words) and then pad the total packets' length with zeros to 32-bit words.

We would of course appreciate a PR for padding in uvgRTP. ;)

Closing as a duplicate of #137

jrsnen commented 2 years ago

image