ultravideo / uvgRTP

An open-source library for RTP/SRTP media delivery
BSD 2-Clause "Simplified" License
318 stars 90 forks source link

H26x: uvgRTP seems to sometimes send the same video frame multiple times #140

Closed jrsnen closed 2 years ago

jrsnen commented 2 years ago

This isn't causing frame loss, but it doesn't really serve any purpose to send more video data than necessary.

This was indicated in format tests with many duplicate fragment prints when the amount of sent and received packets was the same.

jrsnen commented 2 years ago

This was caused by an automatic buffer increasing feature and was relevant only for large frame sizes. I removed this feature in 0d795f5f8ae8c008282edaebef0fc554c305f0a3 since implementing it correctly would have slowed down the reception too much.

If experiencing frame loss, please increase the buffer with configure_ctx()-function on the receiver with RCC_UDP_RCV_BUF_SIZE variable and adopt the fps api on the sending side with RCC_FPS_ENUMERATOR.