ultravioletrs / cocos

Cocos AI - Confidential Computing System for AI

https://ultraviolet.rs/cocos.html

Apache License 2.0

25 stars 9 forks source link

COCOS-242-Agent tests fail ocassionally due to a missing mock #251

Closed smithjilks closed 1 month ago

smithjilks commented 2 months ago

What type of PR is this?

This is a bug fix because it fixes occasional failure of agent service tests.

What does this do?

Adds clean up of venv files after algorithm run. Ensures all mock calls are made and defined.

Which issue(s) does this PR fix/relate to?

Related PR #248
Resolves #242

Have you included tests for your changes?

Yes. This PR fixes failing tests.

Did you document any new/modified feature?

No documentation needed.

Notes

WashingtonKK commented 1 month ago

Does this solve the issue with the missing mock?

It does, I am just wondering if the issue was caused by the files not removed after the test

smithjilks commented 1 month ago

Does this solve the issue with the missing mock?

It does, I am just wondering if the issue was caused by the files not removed after the test

Yeah. I noticed the issue isn't present after these changes. However this does not entirely explain the cause. Please test a few more times to be sure.