uludaggonul / snow-dots

Automatically exported from code.google.com/p/snow-dots
0 stars 0 forks source link

dotsAllSingletonObjects reset() args miss out on the first initialize() #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
dotsAllSingletonObjects can take property-value pairs in their reset() methods, 
and then re-initialize().  This is fine.

Except, when the object is first created via theObject, only the default 
machine-configuration values are used.  Then the reset() arguments are applied 
and the object is re-initialize()d to reflect the arguments.

Thus, there is always one call to initialize() that's uncontrollable, and could 
cause problems.  Though, I don't think it's causing problems right now, as of 
r400 an current users.

The solution would be to let the reset() arguments propagate to theObject, the 
constructor, and perhaps, initialize(), and apply them before doing any 
initialization work.

This would mean that theObject and, and perhaps initialize() could also take 
arguments at any time, which might be fine.

Original issue reported on code.google.com by Benjamin.Heasly on 28 Sep 2010 at 10:32

GoogleCodeExporter commented 8 years ago
As of r574m the MGL branch contains this change.  reset() arguments propagate 
to theObject() and singleton constructors.

Will close when MGL branch is complete.

Original comment by Benjamin.Heasly on 26 Aug 2011 at 5:48

GoogleCodeExporter commented 8 years ago
Since r632 and the October2011 milestone, this feature is now in trunk/ and 
tags/October2011/

Original comment by Benjamin.Heasly on 5 Oct 2011 at 3:34