Limiters with momery store are not working as expected

[mohamedabozeid]

I was using v2 and upon update to v3, I found the weird behaviour

Steps:

• Create memory storage
• Created 2 limiters with 1 sec and 1 hour rates
• Incrementing both limiter for 10 times and print the remaining
• for some reason the limits are being reseted before expiry time

-- limit is 30 After 1 increments for Key: 1HourKey, Remaining: 29 -- correct After 2 increments for Key: 1HourKey, Remaining: 28 -- correct After 3 increments for Key: 1HourKey, Remaining: 27 -- correct After 4 increments for Key: 1HourKey, Remaining: 26 -- correct After 5 increments for Key: 1HourKey, Remaining: 29 -- wrong , should be 25 After 6 increments for Key: 1HourKey, Remaining: 28 -- wrong , should be 24 After 7 increments for Key: 1HourKey, Remaining: 27 -- wrong , should be 23 After 8 increments for Key: 1HourKey, Remaining: 26 -- wrong , should be 22 After 9 increments for Key: 1HourKey, Remaining: 29 -- wrong , should be 21 After 10 increments for Key: 1HourKey, Remaining: 28 -- wrong , should be 20

package main

import (
    "context"
    "fmt"
    "time"

    "github.com/ulule/limiter/v3"
    "github.com/ulule/limiter/v3/drivers/store/memory"
)

const (
    oneSecKey  = "1SecondKey"
    oneHourKey = "1HourKey"
)

func main() {
    oneSecRate := limiter.Rate{
        Period: 1 * time.Second,
        Limit:  10,
    }

    oneHourRate := limiter.Rate{
        Period: 1 * time.Hour,
        Limit:  30,
    }

    store := memory.NewStore()

    oneSecLimiter := limiter.New(store, oneSecRate)
    oneHourLimiter := limiter.New(store, oneHourRate)

    for i := 1; i <= 10; i++ {
        ctx := context.Background()
        increment(ctx, oneSecLimiter, oneHourLimiter)
        //printStatus(ctx, oneSecLimiter, oneSecKey)
        printStatus(ctx, oneHourLimiter, oneHourKey, i)
    }
}

func printStatus(ctx context.Context, l *limiter.Limiter, key string, incrementCount int) {
    lmCtx, err := l.Peek(ctx, key)
    if err != nil {
        panic(err)
    }

    fmt.Println(fmt.Sprintf("After %d increments for Key: %v, Remaining: %v", incrementCount, key, lmCtx.Remaining))
}

func increment(ctx context.Context, oneSecLimiter, oneHourLimiter *limiter.Limiter) {
    _, err := oneSecLimiter.Get(ctx, oneSecKey)
    if err != nil {
        panic(err)
    }

    _, err = oneHourLimiter.Get(ctx, oneHourKey)
    if err != nil {
        panic(err)
    }
}

[novln]

Hello :wave:

It should be fixed with the latest release: https://github.com/ulule/limiter/releases/tag/v3.11.2

Thank you for bringing this up.

Have a nice day :slightly_smiling_face:

[novln]

@mohamedabozeid Could you confirm if the new version fixed the issue that you noticed on your workload ?

[mohamedabozeid]

Hey @novln , Yes it is fixed with the new version, thank you, much apperciated