Support for Cloudflare TOKEN and proxy status

ulygit / asus_rt_ac68u

Configuration and script for Cloudflare DDNS on Asuswrt-Merlin

MIT License

58 stars 24 forks source link

Support for Cloudflare TOKEN and proxy status #5

Closed bengalih closed 4 years ago

bengalih commented 4 years ago

This is to be used in conjunction with the updated script. It adds:

CLOUDFLARE_API_TOKEN configurable variable. If this is set it will take precedence over the EMAIL and API_KEY (they don't need to be populated).
PROXY_STATE configurable variable which takes 'true' or 'false'. The default previously was 'false' since this is what the API defaults to. This allows setting to 'true' so record can be proxied (orange cloud).

ulygit commented 4 years ago

Please submit your changes as a single, atomic commit as this facilitates management.

bengalih commented 4 years ago

Please submit your changes as a single, atomic commit as this facilitates management.

Sorry, being a newb here. I'm actually just submitting changes via github.com and don't actually have a checkout configured via git on my computer. By "atomic" in this sense do you mean commit the two updated files simultaneously (if that's even possible), or did you mean make one commit for each new feature added (Token/Proxy). ?

ulygit commented 4 years ago

I'm closing this PR as well, so you can commit them together and submit a single, self-contained PR. I see you're including a PROXY_STATE parameter now. I think that's an optional parameter, so I wonder if we need to have that in there. In any case, that's a separate issue, so please open an issue so we can discuss.