ulyngs / open-source-no-distractions-for-youtube

Source code for the app "No Distractions" for YouTube, available for Mac and iOS devices on the App Store: https://apps.apple.com/app/no-distractions-for-youtube/id1482507016
29 stars 4 forks source link

Does not working #30

Closed alltogo91 closed 1 year ago

alltogo91 commented 1 year ago

Has no effect, even if all options are chosen

ulyngs commented 1 year ago

Sorry to hear! I am having a zoom call with another user tomorrow who might be experiencing the same issue.

Can you let me know:

alltogo91 commented 1 year ago

Device: Mac Yes, it is

ulyngs commented 1 year ago

Ok!

Could you

Like so:

Screenshot 2023-01-02 at 14 10 41

Screenshot 2023-01-02 at 14 10 41

alltogo91 commented 1 year ago

Bildschirm­foto 2023-01-02 um 14 55 43 Bildschirm­foto 2023-01-02 um 14 57 06

ulyngs commented 1 year ago

The settings seems ok, so far so good!

Afterwards, do this:

alltogo91 commented 1 year ago

Yes, I use Youtube in German, but enter the page via youtube.com Bildschirm­foto 2023-01-02 um 16 37 05 Bildschirm­foto 2023-01-02 um 16 38 22

Hope every needed information is visible

ulyngs commented 1 year ago

Can you untick 'Recommended videos' then take a screen shot again?

alltogo91 commented 1 year ago

Bildschirm­foto 2023-01-02 um 18 16 28

If i click on Shorts they still available.

ulyngs commented 1 year ago

Ah great, so it seems like it does work after all? (to hide something, you need to untick it -- perhaps this is confusing)

Can you:

alltogo91 commented 1 year ago

Bildschirm­foto 2023-01-02 um 18 58 20

Untick all options, and it works =) Just for troubleshooting purposes...i switch to English, tick option => not working again...

Just a feature request... turning off originals would be great

Thanks for the support. Finite a good extention against distraction, money well invested :D

ulyngs commented 1 year ago

If you click 'save settings', does it still show everything if you go to English and back?

alltogo91 commented 1 year ago

Yes... the behave looks like the booleans of the checkbox are reversed

ulyngs commented 1 year ago

Is it because it is confusing that a ticked checkbox means that an element is shown, instead of that it is hidden?

I was thinking about this, and the reason I designed it this way was that ticking a box to turn something off actually felt more confusing.

What if I add a heading that says 'Content to show' above the checkboxes? Do you think that would make it feel like it wasn't reversed?

alltogo91 commented 1 year ago

My thought was, I have an extention here with which I have a function that helps me to not distract myself (which one? just the ones I choose), so I assumed that I would check the checkbox. But I think that's a personal observation...a headline like you suggest is a good idea and doesn't make it unnecessarily complicated for those who are already used to it.

ulyngs commented 1 year ago

I see what you mean, but I think it is confusing that a checkbox like this would mean that it is 'off':

image

What do you think of this idea: When you check the checkbox, it doesn't show a checkmark, but instead a prohibition sign, like this:

image
alltogo91 commented 1 year ago

Perfect 👍

ulyngs commented 1 year ago

@alltogo91 what do you think of this solution

image