search

ulyssa / iamb

A Matrix client for Vim addicts
https://iamb.chat
Apache License 2.0
608 stars 45 forks source link

Fix newer Clippy warnings for 1.80 #301

Closed jarkkojs closed 2 months ago

jarkkojs commented 3 months ago

I'd like to take this client to my own use but as long as it breaks "broken glass" invariant I really cannot do that ;-) [1]

Is there something broken in the CI, I see that there are some clippy bits but cannot comprehend why those checks are not working?

[1] "Fight software rot" chapter in "Pragmatic Programmer"

ulyssa commented 2 months ago

Thank you for cleaning this up!

Is there something broken in the CI, I see that there are some clippy bits but cannot comprehend why those checks are not working?

Each new edition of Rust/Clippy stablizes or adds new lints. Since I don't want to force folks to have to be responsible for fixing new lints every time there's a new release of Rust, the CI workflow runs Clippy using the MSRV for iamb (currently 1.70) which doesn't warn on the checks fixed here.