search

ulyssa / iamb

A Matrix client for Vim addicts
https://iamb.chat
Apache License 2.0
651 stars 45 forks source link

Authenticated media support #349

Open reynoldsme opened 2 months ago

reynoldsme commented 2 months ago

Matrix v1.11 introduces MSC3916 - Authenticated Media which when implemented and enabled on a homeserver, requires clients to send the users access token with any requests for media files which were uploaded after the setting was enabled.

This is still currently an optional setting, but quick adoption is likely and the matrix.org homeserver itself is scheduled to enable it on September 4th, 2024.

Currently iamb will return the following message when attempting to retrieve new media (media from before the setting was enabled is fine, as expected) from a Synapse server with enable_authenticated_media: True set: [Image error: Matrix(Http(Api(Server(ClientApi(Error { status_code: 404, body: Standard { kind: NotFound, message: "Not found" } })))))]

The Client implementation guidance section of the v1.11 release announcement may be helpful.

reynoldsme commented 2 months ago

Oh, I see. This should happen automatically by updating the matrix-sdk dependency https://github.com/matrix-org/matrix-rust-sdk/pull/3598 from 0.7.1 to something newer, but that either has not been released and/or the crates.io entry has not been updated yet. https://crates.io/crates/matrix-sdk

reynoldsme commented 1 month ago

I tried changing the version property of the matrix-sdk dependency to a git reference the latest commit of main on the matrix-rust-sdk in Cargo.toml, but I found there were a few breaking changes. Someone with a better understanding of the codebase and the matrix rust sdk may want to have look, it could be the needed changes are actually minimal.

reynoldsme commented 1 month ago

Looks like https://github.com/matrix-org/matrix-rust-sdk/issues/3742 is the issue to watch for any planned release of matrx-rust-sdk.