ulyssa / modalkit

A Rust library for building modal editing applications
Apache License 2.0
49 stars 5 forks source link

Ignore Shift when comparing character keys #117

Closed ulyssa closed 1 year ago

ulyssa commented 1 year ago

Someone reported issues with pressing : on Windows over at ulyssa/iamb#109. The issue there is that modifiers contains KeyModifiers::SHIFT on Windows, but not on other platforms, because of differences in how crossterm constructs the value. Since SHIFT isn't important for comparing KeyCode::Char keypresseses, I should be able to just remove it when constructing TerminalKey.