ulyssa / modalkit

A Rust library for building modal editing applications
Apache License 2.0
58 stars 8 forks source link

Change default for `last_column` in `EditContext` #146

Closed ulyssa closed 3 months ago

ulyssa commented 3 months ago

While looking into ulyssa/iamb#297, I think I've convinced myself that the default that EditContext/EditContextBuilder uses for last_column is wrong and a potential footgun that results in accidentally misusing InsertTextAction and others outside of a keybinding context. It should default to true so that building Action values from scratch don't unexpectedly clamp the cursor, but require explicitly requesting that behaviour via the builder interface.