search

ulysseB / telamon

A framework to find good combinations of optimizations for computational kernels on GPUs.
https://ulysseb.github.io/telamon/telamon
Apache License 2.0
23 stars 6 forks source link

Remove lifetime from codegen::Size #292

Closed Elarnon closed 5 years ago

Elarnon commented 5 years ago

Since we now use Arc for representing parameters, this patch removes the last use of reference for them in codegen::Size and codegen::ParamVal. Removing the lifetimes in those two types simplifies the lifetime constraints in the code generation phase, and allows to remove the two remaining uses of unsafe in that module that were (presumably) born out of frustration.

andidr commented 5 years ago

Since we now use Arc for representing parameters, this patch removes the last use of reference for them in codegen::Size and

codegen::Size

codegen::ParamVal. Removing the lifetimes in those two types simplifies

codegen::ParamVal

the lifetime constraints in the code generation phase, and allows to remove the two remaining uses of unsafe in that module that were (presumably) born out of frustration.

That's speculation ;)