search

uma-pi1 / kge

LibKGE - A knowledge graph embedding library for reproducible research
MIT License
765 stars 124 forks source link

overwrite dataset-config options only if default is currently set #249

Closed AdrianKs closed 2 years ago

AdrianKs commented 2 years ago

Config options defined in config.yaml or directly in the terminal regarding the dataset are currently overwritten by dataset.yaml; e.g. filenames. We print to the console the options defined by the user but do not apply them.

This PR fixes this behavior and dataset.yaml only overwrites default options, now.

rgemulla commented 2 years ago

Ok with me. A few comments:

  1. Perhaps add a comment to the default_options field stating what it's used for.
  2. Is the config printed the one that's actually used?
  3. If a config option is not applied because it's default has been changed, we may want to print a warning.
AdrianKs commented 2 years ago

Fixed the nested lookup for the default options.

  1. Done
  2. Moved dumping of config after dataset and job creation.
  3. Done