Closed ppoffice closed 1 year ago
Any update on this?
Thanks for the PR.
However, currently there is still the issue that .yaml
files don't seem to be included. In particular, config-default.yaml
and all other yaml files configuring models and embedders.
Also, I am not sure yet, if downloading the data would work in the current setup.
Do you have an idea how this can be fixed?
@AdrianKs It appears that the location of the dataset is closely tied to the location of the kge modules. In order to turn libkge into a library that can be installed from Git or Pip, a significant refactoring of the dataset creation logic is inevitable. As a result, I will be closing this PR for now.
When kge is installed directly from its Git URL using pip or other python dependency managers, its submodules will be omitted because the packages are not correctly defined in the
setup.py
.Only these files will be present in the installed package:
This fix is to include all packages under
kge/
so that a user can correctly installkge
without having to clone the repository first.