search

uma-pi1 / kge

LibKGE - A knowledge graph embedding library for reproducible research
MIT License
765 stars 124 forks source link

fix incorrect dependency version requirement #271

Closed ppoffice closed 1 year ago

ppoffice commented 1 year ago

See https://github.com/pypa/packaging/issues/645

AdrianKs commented 1 year ago

Thank you for the PR. We would like to be able to always use the newest version of the packages if possible. Therefore, it would be preferable to remove the wildcard instead of the >=. numpy>=1.19.0

ppoffice commented 1 year ago

@AdrianKs Here you go.

BTW, I think using compatible release versions instead of the latest version will ensure dependency compatibility. For instance, you can't prevent pip from installing numba 1.0.0 when it's available if you set numba>=0.50.0 as a dependency. And usually a major upgrade like 0.x.x to 1.0.0 introduces breaking changes. On the contrary, setting numba~=0.50.0 will make sure you never upgrade to numba 1.0.0.

ppoffice commented 1 year ago

Would you kindly merge this PR if there is no more issue with it? Thanks.

AdrianKs commented 1 year ago

Yes, sure. Sorry for the late reply. Thank you for the pointer to using ~=. We will merge as it is for now with >= and discuss later on how we want to treat major releases of packages.