umageddon / namDHC

Windows frontend for CHDMAN - written in Autohotkey
GNU General Public License v3.0
311 stars 12 forks source link

Program keeps crashing, no report or confirmation #10

Closed ArcadeDigger closed 1 year ago

ArcadeDigger commented 1 year ago

Program/GUI crashes/disappears during batch progress, So I don't know if it's still running in the background or not and if the conversion is successful. If I add console and the verboes window I see that GUI and the verbose window disappears, only the console is left until work is done and then disappears. No report or confirmation. This happens even when choosing to convert only 1 file as well, not batch.

On Windows 10.

TomTurbine commented 1 year ago

First time I have tried this and can confirm. Had queued up a bunch of Bin/Cue to convert to CHD and it crashed within the first 10 files. Just closes out entirely.

But does look really nice though with a lot of potential.

Edit: Also on Windows 10.

ArcadeDigger commented 1 year ago

Have now tried 1.08 (previous version) and no issues. Everything seems to work fine for me on 1.08, but crashes on 1.09. So something seemed to have happen in the new release. Stuff went really slowly on my computer as well, when I used 1.09. Could not do anything while it was active. No issues with 1.08

umageddon commented 1 year ago

Ok when im home ill look into it. Thanks

umageddon commented 1 year ago

Let me know if v1.10 fixed the problem

ArcadeDigger commented 1 year ago

Fixed the slowdown, but not the crash/shutdown.

GUI-program crashes/disappears but console windows are still up. program crashed about when I was about 40-50% through processing two files. Console windows show process continued and were completed, then they disappear directly after completion. No report or confirmation.

Tried it first with one file and then a batch with two files.

umageddon commented 1 year ago

Hmm... trying to reproduce on my machine here

Are you converting to CHD or from CHD?

Also are any of the files ZIP?

TomTurbine commented 1 year ago

When I did it, I was using uncompressed files in Bin/Cue format in folders.

I had queued up 2,000 PSX games all in separate folders. The app found all of them and then started to process them but crashed within the first 10 files. Haven't tried the updated one though.

umageddon commented 1 year ago

Please report back when you have time if the latest release fixed the issue. Thanks!

ArcadeDigger commented 1 year ago

Seems to have fixed the crashes. :) Tried a Bin-cue file without issue, then tried two iso-files no issue. To CHD. But... the slowdown is back, at least when I tried two files at the same time. Meaning for instance erratic mouse cursor behaviour and difficult to control. The cursor continues to move and drift after stopped moving the mouse. Making it difficult for example to edit this text, if I have to go back and select a word or place with the mouse. So it works, but it's difficult to do other stuff on the computer at the same time. Did not notice the slowdown when I tried 1.08.

Windows 10 is on a m2 ssd, Namdhc and files on a external hdd. AMD Ryzen 5 2600X Six-Core Processor 3.60 GHz 16 gb RAM and a 2070 gfx card.

Update: tried to limit CPU threads to 6 instead of 12. no slowdown when doing two files at once at 6 thread-limit.

umageddon commented 1 year ago

Thanks for the testing and update! Were you running multiple chdman instances simultaneously as well? I can try and slow down some Autohotkey polling, but it sounds like chdman is hogging your resources.

ArcadeDigger commented 1 year ago

Just the one instance via namDHC, two files at once. So two instances via NamDHC? Slowed down when I had the preselected 12 CPU threads. Less/none when I have 6 threads and 2-4 files at once. A bit of a slowdown for the system if I go over 4 files at once.

Starlightbotanist commented 1 year ago

I was also having issues starting with v1.09 I think. Trying v1.11 seems great. No crashes. I usually do 3 threads, so I didn't have slowdown before or currently. 3 is able to utilize 100% of my CPU (ryzen 7 5800h), so I don't think it would be faster to increase the threads.

I tested v1.11 with 25 PS2 games, I decompressed and recompressed them twice without issue.

TomTurbine commented 1 year ago

Just tried it with some PS2 games with the newest version. Didn't crash by I had 2 errors where they timed out within the first 20 files.

Off topic for a possible future feature, CHDMan typically extracts Bin/Cue into a single bin file, could have it work with BinMerge to split them back into individual tracks again which would match the ReDump dat files again.

Edit: With it timing out, one thing I thought of, if others are using an SSD it would go quicker, but I am running it off of an 18TB Hard drive which would make it take longer by comparison.

https://github.com/putnam/binmerge

umageddon commented 1 year ago

When/if I get time I may look into binmerge. I'm personally not stoked on the idea seeing as I like keeping the program simple and to the point of it's purpose. In this case, namdhc is simply a front-end for chdman