search

umair1112 / sipservlets

Automatically exported from code.google.com/p/sipservlets
0 stars 0 forks source link

Support for Call-ID including ')' character #207

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

Current code in SessionManagerUtil.parseSipSessionKey() assumes that the ')' 
character is the one enclosing the session key.

This is incorrect as Call-ID can include ')' character (see below ABNF 
extracted from RFC3261). If this happens, parsing fails and sip sessions are no 
longer accessible.

Call-ID  =  ( "Call-ID" / "i" ) HCOLON callid
callid   =  word [ "@" word ]
word        =  1*(alphanum / "-" / "." / "!" / "%" / "*" /
               "_" / "+" / "`" / "'" / "~" /
               "(" / ")" / "<" / ">" /
               ":" / "\" / DQUOTE /
               "/" / "[" / "]" / "?" /
               "{" / "}" )

Original issue reported on code.google.com by josemre...@gmail.com on 17 Apr 2013 at 1:18

GoogleCodeExporter commented 9 years ago 

See commit 
http://code.google.com/p/sipservlets/source/detail?r=9265dda4c20f130c18bb030308e
6efbf63305a7b&name=issue-207

Original comment by josemre...@gmail.com on 17 Apr 2013 at 1:41

GoogleCodeExporter commented 9 years ago 
George, please integrate for master and both telscale branches.

Original comment by jean.deruelle on 3 Jul 2013 at 8:53

GoogleCodeExporter commented 9 years ago 
Issue 196 has been merged into this issue.

Original comment by jean.deruelle on 3 Jul 2013 at 8:57

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision e149098947ec.

Backport to master

Current code in SessionManagerUtil.parseSipSessionKey() assumes that the only 
')' character in a key is the one enclosing the session key.

This is incorrect in general as the key includes the Call-ID and Call-ID can 
include ')' character (see below ABNF extracted from RFC3261). If this happens, 
parsing fails and sip sessions are no longer accessible.
(cherry picked from commit 9265dda4c20f130c18bb030308e6efbf63305a7b)

Original comment by josemre...@gmail.com on 5 Jul 2013 at 12:26

GoogleCodeExporter commented 9 years ago

Original comment by jean.deruelle on 5 Jul 2013 at 12:34

GoogleCodeExporter commented 9 years ago 
Issue 196 has been merged into this issue.

Original comment by jean.deruelle on 12 Jul 2013 at 3:52