umair13adil / flutter_logs

An extensive logging framework developed for flutter apps.
https://itnext.io/sending-logs-from-flutter-apps-in-real-time-using-elk-stack-mqtt-c24fa0cb9802
Apache License 2.0
40 stars 32 forks source link

exportLogs should return Future<void> instead of void #28

Closed PhenixZeller closed 2 years ago

PhenixZeller commented 2 years ago

Currently when you use FlutterLogs.exportLogs(); in an async function, you can´t await it, because it is not a Future.

https://github.com/umair13adil/flutter_logs/blob/174350f1039dfeca7e175fe17b2922fb70e0660b/lib/flutter_logs.dart#L301

umair13adil commented 2 years ago

@PhenixZeller Noted, this will be done in the next release of the plugin.

MrCsabaToth commented 2 years ago

In the pull request I converted all static void async to return Future<void>