Only create virtual file with common groups

zcapjdb commented 11 months ago

Summary

This pull request introduces the following changes

If two h5 files contain groups A,B,C in file 1 and A,B in file 2, currently vds.py will fail, now it will create a file containing groups A,B

Relates to the following issues

Conformity

[x] Changelog entry
[x] Documentation

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (900d182) 97.90% compared to head (79e9d7f) 97.87%.

Files	Patch %	Lines
ftag/vds.py	90.90%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #63 +/- ## ========================================== - Coverage 97.90% 97.87% -0.03% ========================================== Files 33 33 Lines 1765 1791 +26 ========================================== + Hits 1728 1753 +25 - Misses 37 38 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samvanstroud commented 9 months ago

Hi @zcapjdb, can you resolve the conflicts here? thanks!

umami-hep / atlas-ftag-tools