umami-hep / puma

puma - Plotting UMami Api
Apache License 2.0
4 stars 27 forks source link

Add prob plots to HLAPI #183

Closed samvanstroud closed 1 year ago

samvanstroud commented 1 year ago

Summary

This pull request introduces the following changes

Relates to the following issues

Conformity

codecov-commenter commented 1 year ago

Codecov Report

Merging #183 (da3f55e) into main (3941474) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   97.25%   97.28%   +0.03%     
==========================================
  Files          33       33              
  Lines        2875     2914      +39     
==========================================
+ Hits         2796     2835      +39     
  Misses         79       79              
Impacted Files Coverage Δ
puma/tests/test_histogram.py 100.00% <ø> (ø)
puma/hlplots/results.py 94.79% <100.00%> (+0.85%) :arrow_up:
puma/hlplots/tagger.py 97.22% <100.00%> (+0.07%) :arrow_up:
puma/plot_base.py 90.30% <100.00%> (-0.09%) :arrow_down:
puma/tests/hlplots/test_results.py 99.32% <100.00%> (+0.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dkobylianskii commented 1 year ago

If you have time, you can fix tests for hlplots. Otherwise, we can merge now, and I will fix the tests in the next MR.

samvanstroud commented 1 year ago

Thanks for the look @dkobylianskii, coverage should be fixed with the last two commits.