Closed dkobylianskii closed 1 year ago
Merging #195 (970f5f3) into main (b790ea5) will decrease coverage by
0.04%
. Report is 3 commits behind head on main. The diff coverage is96.68%
.
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
- Coverage 97.32% 97.29% -0.04%
==========================================
Files 33 35 +2
Lines 2986 3137 +151
==========================================
+ Hits 2906 3052 +146
- Misses 80 85 +5
Files Changed | Coverage Δ | |
---|---|---|
puma/integrated_eff.py | 94.73% <94.73%> (ø) |
|
puma/__init__.py | 100.00% <100.00%> (ø) |
|
puma/tests/test_integrated_eff.py | 100.00% <100.00%> (ø) |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Looks great to me @dkobylianskii, can you add a docs page with this new type of plot? thanks!
Looks great to me @dkobylianskii, can you add a docs page with this new type of plot? thanks!
Hi @sam, I added a docs page. However, I don't know how to upload pictures for docs to the git. Can you help me?
Thanks @dkobylianskii! I always just used HTML tags, see https://github.com/umami-hep/puma/blob/087299088fdee9c34f2c1d7b3f3f1f8c807f9221/docs/source/examples/high_level_api.md?plain=1#L29. Would that work for what you wanted to do? Then we just need to commit the image somewhere in the repo, either in docs/assets or the example materials dir
@afroch I think you need to approve your requested changes here
Summary
This pull request introduces the following changes
Relates to the following issues
43
Conformity