search

umami-hep / puma

puma - Plotting UMami Api
Apache License 2.0
4 stars 27 forks source link

Support for older versions of matplotlib.Figure #199

Closed biemster closed 1 year ago

biemster commented 1 year ago

Setting the layout in Figure to constrained can be done in multiple ways. The version of matplotlib bundled with LCG 102 / current athena 23.0 is 3.3.something, and only supports the constrained_layout=True way, not layout="constrained". Together with PR #198 this change makes puma fully compatible with latest numpy and matplotlib, and the versions currently pulled in with asetup Athena,23.0.

codecov-commenter commented 1 year ago

Codecov Report

Merging #199 (646ab77) into main (b790ea5) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          33       33           
  Lines        2986     2986           
=======================================
  Hits         2906     2906           
  Misses         80       80
Files Changed Coverage Δ
puma/plot_base.py 90.30% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more