umami-hep / puma

puma - Plotting UMami Api
Apache License 2.0
4 stars 27 forks source link

Addition of vertexing performance tools #216

Closed jmw464 closed 9 months ago

jmw464 commented 11 months ago

Summary

This pull request introduces the following changes

Conformity

codecov[bot] commented 11 months ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (126d210) 97.27% compared to head (8bdafe8) 96.88%.

:exclamation: Current head 8bdafe8 differs from pull request most recent head 898023a. Consider uploading reports for the commit 898023a to get more accurate results

Files Patch % Lines
puma/utils/generate.py 5.55% 17 Missing :warning:
puma/var_vs_aux.py 90.56% 10 Missing :warning:
puma/hlplots/aux_results.py 96.34% 3 Missing :warning:
puma/tests/hlplots/test_aux_results.py 98.57% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== - Coverage 97.27% 96.88% -0.40% ========================================== Files 35 41 +6 Lines 3412 3946 +534 ========================================== + Hits 3319 3823 +504 - Misses 93 123 +30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkobylianskii commented 10 months ago

Hi @jmw464 ,

Thanks a lot for this MR, it looks nice. Few comments: