Draft: modify top label in Xbb and add catch for legacy tagger plotting

umami-hep / puma

puma - Plotting UMami Api

Apache License 2.0

4 stars 27 forks source link

Draft: modify top label in Xbb and add catch for legacy tagger plotting #222

Open philippgadow opened 10 months ago

philippgadow commented 10 months ago

Summary

This pull request introduces the following changes

modify the Xbb label in the high level plotting interface from top to tqqb.
add try / except block to catch cases where legacy configurations are plotted

Conformity

[ ] Changelog entry
[ ] Documentation

samvanstroud commented 10 months ago

Looks good thanks @philippgadow! Would be great if @zcapjdb can take a quick look too :)

zcapjdb commented 10 months ago

This looks good to me. Although I'm not sure if we should only look at the fully contained tops by default for the plotting

dkobylianskii commented 9 months ago

Hi @philippgadow ,

Thanks for the MR! Could you please fix formatting and tests?

samvanstroud commented 9 months ago

https://github.com/umami-hep/atlas-ftag-tools/pull/55 should help here :)

samvanstroud commented 7 months ago

Hi @philippgadow, just a gentle nudge on this, it would be good to have this merged since we actually updated the tools package version recently https://github.com/umami-hep/puma/blob/main/requirements.txt#L16. I can't remember if this would cause confusion but pinging @zcapjdb to let him know in any case