umami-hep / puma

puma - Plotting UMami Api
Apache License 2.0
4 stars 27 forks source link

Generalize and refine aux task plotting tools #229

Closed jmw464 closed 8 months ago

jmw464 commented 9 months ago

Summary

This pull request introduces the following changes

Conformity

codecov[bot] commented 9 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (de99e3f) 97.15% compared to head (81043e6) 97.26%.

Files Patch % Lines
puma/hlplots/aux_results.py 93.50% 5 Missing :warning:
puma/hlplots/tagger.py 94.87% 2 Missing :warning:
puma/var_vs_var.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #229 +/- ## ========================================== + Coverage 97.15% 97.26% +0.11% ========================================== Files 45 46 +1 Lines 4466 4646 +180 ========================================== + Hits 4339 4519 +180 Misses 127 127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkobylianskii commented 8 months ago

Looks amazing! Thanks @jmw464 I think that we can merge after resolving all @samvanstroud comments and fixing conflicts.