umami-hep / puma

puma - Plotting UMami Api
Apache License 2.0
4 stars 27 forks source link

Plot all taggers if no option specified #248

Closed nikitapond closed 6 months ago

nikitapond commented 6 months ago

Summary

This pull request introduces the following changes

Relates to the following issues

Conformity

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.72%. Comparing base (324f4be) to head (12e6e5e).

Files Patch % Lines
puma/hlplots/yuma.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== - Coverage 97.77% 97.72% -0.05% ========================================== Files 43 43 Lines 4486 4489 +3 ========================================== + Hits 4386 4387 +1 - Misses 100 102 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samvanstroud commented 6 months ago

Thanks!]

]I thought was already working - did #247 break it?

nikitapond commented 6 months ago

It wasn't "broken" as such, but I noticed in the GN2 plots repo, you don't have a 'taggers: ' in the plot config, and so when checking if a tagger was present, it just crashed. I.e, this could just be fixed by changing configs, but I think plotting all taggers by default is logical.

samvanstroud commented 6 months ago

I'm confused - the plots in the GN2 plots repo are running for me as is

nikitapond commented 6 months ago

Thats weird, for me its crashing here, as self.taggers is None