Closed nikitapond closed 6 months ago
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 97.72%. Comparing base (
324f4be
) to head (12e6e5e
).
Files | Patch % | Lines |
---|---|---|
puma/hlplots/yuma.py | 33.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!]
]I thought was already working - did #247 break it?
It wasn't "broken" as such, but I noticed in the GN2 plots repo, you don't have a 'taggers: ' in the plot config, and so when checking if a tagger was present, it just crashed. I.e, this could just be fixed by changing configs, but I think plotting all taggers by default is logical.
I'm confused - the plots in the GN2 plots repo are running for me as is
Thats weird, for me its crashing here, as self.taggers
is None
Summary
This pull request introduces the following changes
Relates to the following issues
Conformity